danny0405 commented on code in PR #12984:
URL: https://github.com/apache/hudi/pull/12984#discussion_r2002213885


##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -901,6 +919,53 @@ public static HoodieData<HoodieRecord> 
convertMetadataToRecordIndexRecords(Hoodi
     }
   }
 
+  static Set<String> getValidRecordKeysForFileSlice(HoodieTableMetaClient 
metaClient,

Review Comment:
   >  to add ordering value to RLI entry of each record, so that we can use the 
order value when updating the metadata payload record in RLI in the correct 
ordering based on the merge mode.
   
   This looks like the right fix for me. And it is very related to the delete 
block processing time semantics lost issue:
   https://github.com/apache/hudi/pull/12971#discussion_r1993030977



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to