danny0405 commented on code in PR #12967:
URL: https://github.com/apache/hudi/pull/12967#discussion_r1998080112
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java:
##########
@@ -311,25 +311,42 @@ public static Schema addMetadataFields(Schema schema) {
* @param withOperationField Whether to include the '_hoodie_operation' field
*/
public static Schema addMetadataFields(Schema schema, boolean
withOperationField) {
- int newFieldsSize = HoodieRecord.HOODIE_META_COLUMNS.size() +
(withOperationField ? 1 : 0);
+ return addMetadataFields(schema, true, withOperationField);
+ }
+
+ /**
+ * Adds the Hoodie metadata fields to the given schema.
+ *
+ * @param schema The schema
+ * @param isPopulateMetaFields Whether to include metadata fields
+ * @param withOperationField Whether to include the '_hoodie_operation'
field
+ */
+ public static Schema addMetadataFields(Schema schema, boolean
isPopulateMetaFields, boolean withOperationField) {
Review Comment:
Not sure why we need this chagne, the method name and parameter
`isPopulateMetaFields` conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
