This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push: new 717a3045556 [MINOR] Improve error logs on mdt validation job (#12973) 717a3045556 is described below commit 717a304555690618e0415e64ef6ba9bfcfe19a19 Author: Tim Brown <t...@onehouse.ai> AuthorDate: Thu Mar 13 19:57:24 2025 -0500 [MINOR] Improve error logs on mdt validation job (#12973) --- .../apache/hudi/utilities/HoodieMetadataTableValidator.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java index 4ab009984e8..17ac8a66070 100644 --- a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java +++ b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java @@ -541,7 +541,7 @@ public class HoodieMetadataTableValidator implements Serializable { try { return doMetadataTableValidation(); } catch (Throwable e) { - LOG.error("Metadata table validation failed to HoodieValidationException {} {}", taskLabels, e); + LOG.error("Metadata table validation failed to HoodieValidationException {}", taskLabels, e); if (!cfg.ignoreFailed) { throw e; } @@ -615,12 +615,12 @@ public class HoodieMetadataTableValidator implements Serializable { HoodieMetadataValidationContext fsBasedContext = new HoodieMetadataValidationContext(engineContext, props, metaClient, false, cfg.viewStorageTypeForFSListing)) { Set<String> finalBaseFilesForCleaning = baseFilesForCleaning; - List<Pair<Boolean, ? extends Exception>> result = new ArrayList<>( + List<Pair<Boolean, HoodieValidationException>> result = new ArrayList<>( engineContext.parallelize(allPartitions, allPartitions.size()).map(partitionPath -> { try { validateFilesInPartition(metadataTableBasedContext, fsBasedContext, partitionPath, finalBaseFilesForCleaning); LOG.info("Metadata table validation succeeded for partition {} (partition {})", partitionPath, taskLabels); - return Pair.<Boolean, Exception>of(true, null); + return Pair.<Boolean, HoodieValidationException>of(true, null); } catch (HoodieValidationException e) { LOG.error("Metadata table validation failed for partition {} due to HoodieValidationException (partition {})", partitionPath, taskLabels, e); @@ -656,10 +656,10 @@ public class HoodieMetadataTableValidator implements Serializable { handleValidationException(e, result, "Metadata table validation failed due to HoodieValidationException in partition stats validation"); } - for (Pair<Boolean, ? extends Exception> res : result) { + for (Pair<Boolean, HoodieValidationException> res : result) { finalResult &= res.getKey(); if (res.getKey().equals(false)) { - LOG.error("Metadata Validation failed for table: {} with error: {}", cfg.basePath, res.getValue()); + LOG.error("Metadata Validation failed for table: {}", cfg.basePath, res.getValue()); if (res.getRight() != null) { throwables.add(res.getRight()); } @@ -688,7 +688,7 @@ public class HoodieMetadataTableValidator implements Serializable { } } - private void handleValidationException(HoodieValidationException e, List<Pair<Boolean, ? extends Exception>> result, String errorMsg) { + private void handleValidationException(HoodieValidationException e, List<Pair<Boolean, HoodieValidationException>> result, String errorMsg) { LOG.error("{} for table: {} ", errorMsg, cfg.basePath, e); if (!cfg.ignoreFailed) { throw e;