lokeshj1703 commented on code in PR #12935:
URL: https://github.com/apache/hudi/pull/12935#discussion_r1993937794
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieBaseFileGroupRecordBuffer.java:
##########
@@ -424,8 +424,10 @@ protected Option<T> merge(Option<T> older, Map<String,
Object> olderInfoMap,
}
Comparable oldOrderingValue = readerContext.getOrderingValue(
older, olderInfoMap, readerSchema, orderingFieldName);
- if (!isDeleteRecordWithNaturalOrder(older, oldOrderingValue)
- && oldOrderingValue.compareTo(newOrderingValue) > 0) {
+ boolean choosePrev = !oldOrderingValue.equals(0)
+ && ReflectionUtils.isSameClass(oldOrderingValue,
newOrderingValue)
Review Comment:
@linliu-code Can you check this issue? It seems like default ordering value
should be used only with delete payload. Somehow with version 6, we are still
seeing default ordering value being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
