danny0405 commented on code in PR #12956:
URL: https://github.com/apache/hudi/pull/12956#discussion_r1990440710
##########
hudi-common/src/main/java/org/apache/hudi/common/util/collection/DiskMap.java:
##########
@@ -26,18 +26,22 @@
import java.io.File;
import java.io.IOException;
import java.io.Serializable;
+import java.util.Collections;
+import java.util.HashSet;
import java.util.Map;
+import java.util.Set;
import java.util.UUID;
import java.util.stream.Stream;
/**
- * This interface provides the map interface for storing records in disk after
they
+ * This interface provides the map interface for storing records in disk after
+ * they
* spill over from memory. Used by {@link ExternalSpillableMap}.
*
* @param <T> The generic type of the keys
* @param <R> The generic type of the values
*/
-public abstract class DiskMap<T extends Serializable, R> implements Map<T, R>,
KeyFilteringIterable<T, R>, AutoCloseable {
+public abstract class DiskMap<T extends Serializable, R extends Serializable>
implements Map<T, R>, Iterable<R> {
Review Comment:
Why change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
