yihua commented on code in PR #12943:
URL: https://github.com/apache/hudi/pull/12943#discussion_r1987807735
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCleanConfig.java:
##########
@@ -77,9 +80,9 @@ public class HoodieCleanConfig extends HoodieConfig {
.withDocumentation(HoodieCleaningPolicy.class)
.markAdvanced()
.withInferFunction(cfg -> {
- boolean isCommitsRetainedConfigured =
cfg.contains(CLEANER_COMMITS_RETAINED_KEY);
- boolean isHoursRetainedConfigured =
cfg.contains(CLEANER_HOURS_RETAINED_KEY);
- boolean isFileVersionsRetainedConfigured =
cfg.contains(CLEANER_FILE_VERSIONS_RETAINED_KEY);
+ boolean isCommitsRetainedConfigured =
cfg.contains(CLEANER_COMMITS_RETAINED_KEY) ||
cfg.contains(CLEANER_COMMITS_RETAINED_ALTERNATIVE_KEY);
Review Comment:
We should revisit the impact of ordering of config definition for inferring
the config values in a follow-up (HUDI-9153), as this pattern is used in other
places and can be disturbed easily by changing the order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
