Davis-Zhang-Onehouse commented on code in PR #12646:
URL: https://github.com/apache/hudi/pull/12646#discussion_r1927816582
##########
hudi-common/src/main/java/org/apache/hudi/common/table/TableSchemaResolver.java:
##########
@@ -222,6 +244,50 @@ private Option<Schema>
getTableSchemaFromLatestCommitMetadata(boolean includeMet
}
}
+ public Option<Schema> getTableAvroSchemaIfPresentV2(boolean
includeMetadataFields) {
Review Comment:
I want to limit the impact of the API to only our use case, later as I pull
the rest of the work of concurrent schema evolution into OSS, I can replace all
the old implementation
the main concern is there are unknown unknowns on what could happen of
today's system, they might have weird assumptions that the new API does not
support and we should fail, then we need to fix tests, etc. To ensure the item
ship on time, I deprioritize that and leave it as a future work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
