danny0405 commented on code in PR #12424:
URL: https://github.com/apache/hudi/pull/12424#discussion_r1870538411
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseActionExecutor.java:
##########
@@ -161,4 +162,20 @@ protected final void dropIndexOnRestore() {
}
}
}
+
+ protected final void maybeDisableWriteRecordPositions() {
Review Comment:
I don't think we should fix it in the executors, because COW table also
share these executors. I kind of think we should fix it in the
`HoodieAppendHandle`.
```java
this.shouldWriteRecordPositions = config.shouldWriteRecordPositions()
// record positions supported only from table version 8
&&
config.getWriteVersion().greaterThanOrEquals(HoodieTableVersion.EIGHT);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
