lw309637554 opened a new pull request #2099: URL: https://github.com/apache/hudi/pull/2099
## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the pull request in UpgradeDowngrade.run() fs.rename(updatedPropsFilePath, propsFilePath); the fs.rename have different action,such as: // a) for hdfs : if propsFilePath already exist,fs.rename will not replace propsFilePath, but just return false // b) for localfs: if propsFilePath already exist,fs.rename will replace propsFilePath, and return ture // c) for aliyun ossfs: if propsFilePath already exist,will throw FileAlreadyExistsException // so we should delete the old propsFilePath. also upgrade and downgrade is Idempotent ## Brief change log *(for example:)* - *Modify AnnotationLocation checkstyle rule in checkstyle.xml* ## Verify this pull request *(Please pick either of the following options)* This pull request is a trivial rework / code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end.* - *Added HoodieClientWriteTest to verify the change.* - *Manually verified the change by running a job locally.* ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit - [ ] Commit message is descriptive of the change - [ ] CI is green - [ ] Necessary doc changes done or have another open PR - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
