yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1811569363
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodiePositionBasedFileGroupRecordBuffer.java:
##########
@@ -199,7 +199,7 @@ public void processNextDeletedRecord(DeleteRecord
deleteRecord, Serializable rec
if (recordOpt.isPresent()) {
String recordKey = recordOpt.get().getRecordKey();
records.put(recordPosition, Pair.of(Option.empty(),
readerContext.generateMetadataForRecord(
- recordKey, recordOpt.get().getPartitionPath(),
recordOpt.get().getOrderingValue(), orderingFieldType)));
+ recordKey, recordOpt.get().getPartitionPath(),
recordOpt.get().getOrderingValue() == null ? orderingFieldDefault :
recordOpt.get().getOrderingValue(), orderingFieldTypeOpt)));
Review Comment:
If it's null, we assume natural ordering. Do we assume the ordering value
to be always non-null in the record buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
