yihua commented on code in PR #11994:
URL: https://github.com/apache/hudi/pull/11994#discussion_r1779818495
##########
docker/hoodie/hadoop/datanode/Dockerfile:
##########
@@ -17,7 +17,7 @@
ARG HADOOP_VERSION=2.8.4
ARG HADOOP_DN_PORT=50075
-FROM apachehudi/hudi-hadoop_${HADOOP_VERSION}-base:latest
+FROM apachehudi/hudi-hadoop_${HADOOP_VERSION}-base:bullseye
Review Comment:
Similar here in `Dockerfile`s: the image tag will be reverted from
`bullseye` to `latest` once the PR is close to merging.
##########
hudi-aws/pom.xml:
##########
@@ -268,11 +269,12 @@
</run>
</image>
<image>
-
<name>motoserver/moto:${moto.version}</name>
+
<name>apachehudi/moto:${moto.version}</name>
Review Comment:
We have to do this to pull the image of the correct architecture as the
plugin cannot do this properly.
##########
hudi-aws/src/test/java/org/apache/hudi/aws/sync/ITTestGluePartitionPushdown.java:
##########
@@ -60,8 +60,9 @@
@Disabled("HUDI-7475 The tests do not work. Disabling them to unblock Azure
CI")
public class ITTestGluePartitionPushdown {
-
- private static final String MOTO_ENDPOINT = "http://localhost:5000";;
+ // This port number must be the same as {@code moto.port} defined in pom.xml
+ private static final int MOTO_PORT = 5002;
+ private static final String MOTO_ENDPOINT = "http://localhost:"; + MOTO_PORT;
Review Comment:
To make this integration test run locally.
##########
hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java:
##########
@@ -170,7 +170,7 @@ private boolean checkHealth(String fromContainerName,
String hostname, int port)
TestExecStartResultCallback resultCallback =
executeCommandStringInDocker(fromContainerName, command, false,
true);
String stderrString = resultCallback.getStderr().toString().trim();
- if (!stderrString.contains("open")) {
+ if (!stderrString.contains("succeeded")) {
Review Comment:
Output message change.
##########
hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestHoodieDemo.java:
##########
@@ -288,12 +290,15 @@ private void testHiveAfterFirstBatch() throws Exception {
private void testSparkSQLAfterFirstBatch() throws Exception {
Pair<String, String> stdOutErrPair =
executeSparkSQLCommand(SPARKSQL_BATCH1_COMMANDS, true);
- assertStdOutContains(stdOutErrPair, "|default |stock_ticks_cow |false
|\n"
- + "|default
|stock_ticks_cow_bs |false |\n"
- + "|default
|stock_ticks_mor_bs_ro |false |\n"
- + "|default
|stock_ticks_mor_bs_rt |false |"
- + "|default
|stock_ticks_mor_ro |false |\n"
- + "|default
|stock_ticks_mor_rt |false |");
+ assertStdOutContains(stdOutErrPair,
+ "|default |stock_ticks_cow |false |\n"
+ + "|default |stock_ticks_cow_bs |false |\n"
+ + "|default |stock_ticks_mor |false |\n"
Review Comment:
Now the original table name is also synced to the metastore based on the
recent behavior change (#10685).
##########
docker/compose/docker-compose_hadoop284_hive233_spark353_amd64.yml:
##########
@@ -37,11 +36,12 @@ services:
retries: 3
datanode1:
- image: apachehudi/hudi-hadoop_2.8.4-datanode:latest
+ image: apachehudi/hudi-hadoop_2.8.4-datanode:bullseye
Review Comment:
The image tag will be reverted from `bullseye` to `latest` once the PR is
close to merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
