codope commented on code in PR #12001:
URL: https://github.com/apache/hudi/pull/12001#discussion_r1775530964
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -316,6 +316,13 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
.withDocumentation("Initializes the metadata table by reading from the
file system when the table is first created. Enabled by default. "
+ "Warning: This should only be disabled when manually constructing
the metadata table outside of typical Hudi writer flows.");
+ public static final ConfigProperty<Boolean> FUNCTIONAL_INDEX_ENABLE_PROP =
ConfigProperty
+ .key(METADATA_PREFIX + ".functional.index.enable")
Review Comment:
You raise a good point. I simply named the key that way because we keep
calling functional index. I noticed that it is only the record index which
deviates from the standard,e.g. bloom filter - `.index.bloom.filter.enable`,
colstats - `.index.column.stats.enable`. So, I am going to rename it to
`.index.functional.enable`. I can take up renaming record index enable key and
use alias for compatibility in a followup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
