CTTY commented on code in PR #10835:
URL: https://github.com/apache/hudi/pull/10835#discussion_r1767650701
##########
hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java:
##########
@@ -113,15 +112,14 @@ public static TypedProperties loadGlobalProps() {
}
}
// Try loading the external config file from local file system
+ try {
+ conf.addPropsFromFile(DEFAULT_PATH);
+ } catch (Exception e) {
+ LOG.warn("Cannot load default config file: " + DEFAULT_PATH, e);
+ }
Review Comment:
+1. The change looks fine to me, but it calls for a doc update as it changes
the expected behavior: the `DEFAULT_CONF` would always be applied unless
overriden by some user conf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
