nsivabalan commented on code in PR #11580:
URL: https://github.com/apache/hudi/pull/11580#discussion_r1679845441
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java:
##########
@@ -113,6 +113,7 @@ protected Option<HoodieRollbackPlan> requestRollback(String
startRollbackTime) {
HoodieRollbackPlan rollbackPlan = new HoodieRollbackPlan(new
HoodieInstantInfo(instantToRollback.getTimestamp(),
instantToRollback.getAction()), rollbackRequests,
LATEST_ROLLBACK_PLAN_VERSION);
if (!skipTimelinePublish) {
+ table.validateForLatestTimestamp(rollbackInstant.getTimestamp());
Review Comment:
not sure how did you arrive at that conclusion. If you look at the scenario
called out in the jira, it could be any of write actions (commits,
deltacommits, replace commits). may be we don't need rollback, but all writes
might def need this fix w/ multi-writer scenarios. for a single writer, anyways
txnManager should be a no-op, and so should not have any impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
