nsivabalan commented on code in PR #11344:
URL: https://github.com/apache/hudi/pull/11344#discussion_r1667085731
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -924,11 +925,11 @@ private void startCommit(String instantTime, String
actionType, HoodieTableMetaC
"Found pending restore in active timeline. Please complete the restore
fully before proceeding. As of now, "
+ "table could be in an inconsistent state. Pending restores: " +
Arrays.toString(inflightRestoreTimeline.getInstantsAsStream()
.map(instant ->
instant.getTimestamp()).collect(Collectors.toList()).toArray()));
+ TimestampUtils.validateForLatestTimestamp(metaClient, instantTime);
Review Comment:
hey @kbuci : for 0.x branch, we are not taking a lock for regular writes,
but table service schedule is all under the block. but we are reloading the
timeline while we do this validation which achieves the same purpose.
in 1.x, commit time generation is w/n a lock. so, we should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
