silly-carbon commented on PR #10989:
URL: https://github.com/apache/hudi/pull/10989#issuecomment-2046983505

   > Nice catch, I was thinking this exception was caused by concurrent access 
of the shutdown hook before #10789, it's greate if this is actually the culprit.
   > 
   > Take a look at the JDK code, the fix makes sense:
   > 
   > ```java
   >     static synchronized boolean remove(Thread hook) {
   >         if(hooks == null)
   >             throw new IllegalStateException("Shutdown in progress");
   > 
   >         if (hook == null)
   >             throw new NullPointerException();
   > 
   >         return hooks.remove(hook) != null;
   >     }
   > ```
   
   Thanks. 
   Yes, it was exactly this piece of JDK code that made me to come up with this 
bug fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to