xuzifu666 commented on code in PR #10801:
URL: https://github.com/apache/hudi/pull/10801#discussion_r1510521354
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -327,8 +327,10 @@ protected void completeCompaction(HoodieCommitMetadata
metadata, HoodieTable tab
try {
this.txnManager.beginTransaction(Option.of(compactionInstant),
Option.empty());
finalizeWrite(table, compactionCommitTime, writeStats);
- // commit to data table after committing to metadata table.
- writeTableMetadata(table, compactionCommitTime, metadata,
context.emptyHoodieData());
+ // if metatable is enable, then commit to data table after committing to
metadata table.
+ if (config.getMetadataConfig().enabled()) {
+ writeTableMetadata(table, compactionCommitTime, metadata,
context.emptyHoodieData());
+ }
LOG.info("Committing Compaction " + compactionCommitTime + ". Finished
with result " + metadata);
Review Comment:
Maybe add a new config to control it could be better，I do the change with
adding a config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
