yihua commented on code in PR #10225:
URL: https://github.com/apache/hudi/pull/10225#discussion_r1423228983


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedParquetFileFormat.scala:
##########
@@ -65,6 +66,8 @@ class HoodieFileGroupReaderBasedParquetFileFormat(tableState: 
HoodieTableState,
                                                   requiredFilters: Seq[Filter]
                                            ) extends ParquetFileFormat with 
SparkAdapterSupport with HoodieFormatTrait {
 
+  override def getRequiredFilters: Seq[Filter] = requiredFilters

Review Comment:
   I'm not particularly asking about this line.  We support `hoodie.data 
source.read.incr.filters` in `IncrementalRelation`.  Wondering if we also have 
the same support in the new file format class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to