yihua commented on code in PR #9716:
URL: https://github.com/apache/hudi/pull/9716#discussion_r1326360160
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCleanConfig.java:
##########
@@ -81,36 +85,37 @@ public class HoodieCleanConfig extends HoodieConfig {
// "hoodie.cleaner.hours.retained" (inferred as KEEP_LATEST_BY_HOURS)
// "hoodie.cleaner.fileversions.retained" (inferred as
KEEP_LATEST_FILE_VERSIONS)
if (isCommitsRetainedConfigured && !isHoursRetainedConfigured &&
!isFileVersionsRetainedConfigured) {
- return Option.of(HoodieCleaningPolicy.KEEP_LATEST_COMMITS.name());
+ return Option.of(KEEP_LATEST_COMMITS.name());
}
if (!isCommitsRetainedConfigured && isHoursRetainedConfigured &&
!isFileVersionsRetainedConfigured) {
- return Option.of(HoodieCleaningPolicy.KEEP_LATEST_BY_HOURS.name());
+ return Option.of(KEEP_LATEST_BY_HOURS.name());
}
if (!isCommitsRetainedConfigured && !isHoursRetainedConfigured &&
isFileVersionsRetainedConfigured) {
- return
Option.of(HoodieCleaningPolicy.KEEP_LATEST_FILE_VERSIONS.name());
+ return Option.of(KEEP_LATEST_FILE_VERSIONS.name());
}
return Option.empty();
});
public static final ConfigProperty<String> CLEANER_COMMITS_RETAINED =
ConfigProperty
.key(CLEANER_COMMITS_RETAINED_KEY)
.defaultValue("10")
- .withDocumentation("Number of commits to retain, without cleaning. This
will be retained for num_of_commits * time_between_commits "
- + "(scheduled). This also directly translates into how much data
retention the table supports for incremental queries.");
+ .withDocumentation("When " + KEEP_LATEST_COMMITS.name() + " cleaning
policy is used, the of commits to retain, without cleaning. "
Review Comment:
```suggestion
.withDocumentation("When " + KEEP_LATEST_COMMITS.name() + " cleaning
policy is used, the number of commits to retain, without cleaning. "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
