the-other-tim-brown commented on code in PR #9543:
URL: https://github.com/apache/hudi/pull/9543#discussion_r1306538031
##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/testutils/TestHoodieMetadataBase.java:
##########
@@ -303,9 +303,7 @@ protected HoodieWriteConfig.Builder
getWriteConfigBuilder(HoodieFailedWritesClea
.ignoreSpuriousDeletes(validateMetadataPayloadConsistency)
.build())
.withMetricsConfig(HoodieMetricsConfig.newBuilder().on(enableMetrics)
- .withExecutorMetrics(enableMetrics).build())
- .withMetricsGraphiteConfig(HoodieMetricsGraphiteConfig.newBuilder()
- .usePrefix("unit-test").build())
+
.withExecutorMetrics(enableMetrics).withReporterType(MetricsReporterType.CONSOLE.name()).build())
Review Comment:
Do we actually use these metrics in the console output? the in memory option
may be better suited for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
