codope commented on code in PR #9502:
URL: https://github.com/apache/hudi/pull/9502#discussion_r1302543971
##########
hudi-utilities/src/test/resources/schema/sample_data_schema.avsc:
##########
@@ -0,0 +1,10 @@
+{
+ "type": "record",
+ "name": "MySchema",
+ "fields": [
+ {
+ "name": "data",
+ "type": "string"
+ }
+ ]
+}
Review Comment:
nit: new line at the end
Also, license header at the top (though it's optional for .avsc files but as
a convention we add here too).
##########
hudi-utilities/src/test/resources/schema/sample_gcs_data.avsc:
##########
@@ -0,0 +1,14 @@
+{
+ "type": "record",
+ "name": "MySchema",
+ "fields": [
+ {
+ "name": "id",
+ "type": ["null", "string"]
+ },
+ {
+ "name": "text",
+ "type": ["null", "string"]
+ }
+ ]
+}
Review Comment:
same comment here - new line and license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
