hbgstc123 commented on code in PR #9226:
URL: https://github.com/apache/hudi/pull/9226#discussion_r1285064569
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ClusteringUtils.java:
##########
@@ -258,26 +258,29 @@ public static Option<HoodieInstant>
getOldestInstantToRetainForClustering(
? cleanInstant
:
HoodieTimeline.getCleanRequestedInstant(cleanInstant.getTimestamp()))
.getEarliestInstantToRetain();
- String retainLowerBound;
+ String instantTimeLowerBound;
Review Comment:
OK, we can add such assurance to
`HoodieCleaningPolicy.KEEP_LATEST_BY_HOURS`, so earliestInstantToRetain should
<= earliest pending instant in terms of timeline.
But since `HoodieCleaningPolicy.KEEP_LATEST_FILE_VERSIONS` don't have
earliestInstantToRetain, we may still need to use StateTransitionTime in
`ClusteringUtils.getOldestInstantToRetainForClustering` when clean policy is
KEEP_LATEST_FILE_VERSIONS.
I will make some change to this pr later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
