yihua commented on code in PR #9255:
URL: https://github.com/apache/hudi/pull/9255#discussion_r1284902386
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDTableServiceClient.java:
##########
@@ -67,8 +68,9 @@ public class SparkRDDTableServiceClient<T> extends
BaseHoodieTableServiceClient<
protected SparkRDDTableServiceClient(HoodieEngineContext context,
HoodieWriteConfig clientConfig,
- Option<EmbeddedTimelineService>
timelineService) {
- super(context, clientConfig, timelineService);
+ Option<EmbeddedTimelineService>
timelineService,
+ Option<TransactionManager> txnManager) {
Review Comment:
Not sure if it's a good idea to expose this in the constructor, as the
client can escape the transaction manager and cause correctness issues in
concurrency control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
