codope commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1226046920


##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataLogRecordReader.java:
##########
@@ -106,10 +107,10 @@ public Map<String, HoodieRecord<HoodieMetadataPayload>> 
getRecordsByKeys(List<St
     //       materialized state, to make sure there's no concurrent access
     synchronized (this) {
       logRecordScanner.scanByFullKeys(keys);
-      return logRecordScanner.getRecords().entrySet()
-          .stream()
+      Map<String, HoodieRecord> allRecords = logRecordScanner.getRecords();

Review Comment:
   We were not filtering on `keys` which contain valid partitions. Due to that 
result from this method also had data for `__all_partitions__` key which is not 
needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to