xushiyan commented on code in PR #8741:
URL: https://github.com/apache/hudi/pull/8741#discussion_r1197664472
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/bulkinsert/TestBulkInsertInternalPartitionerForRows.java:
##########
@@ -103,8 +103,7 @@ public void
testBulkInsertInternalPartitioner(BulkInsertSortMode sortMode,
boolean isGloballySorted,
boolean isLocallySorted,
boolean populateMetaFields) {
- Dataset<Row> records1 = generateTestRecords();
- Dataset<Row> records2 = generateTestRecords();
+ Dataset<Row> records = generateTestRecords();
Review Comment:
the test only passes spark 2.4 which is an coincident. The existing test
logic asserts 2 rdd partitions after re-partition by the partitioner. with
spark 2.4's sort and coalesce, it gives 2 and passes the test as a local
partitioner. The correct expectation is the partitioner is doing global sort
and the resulting num partition should be 2 or less, which is what spark 3
gives us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
