bvaradar commented on PR #7891:
URL: https://github.com/apache/hudi/pull/7891#issuecomment-1451441554

   @SteNicholas : timeline.containsOrBeforeTimelineStarts() returns true if it 
finds the fileId with instant which was archived.  So, Clustering would be fine 
without this change too. right ?  Sorry, I am not able to see the problem with 
the description. Can you kindly elaborate with some scenarios
   
   ```  private boolean isFileSliceCommitted(FileSlice slice) {
       if (!compareTimestamps(slice.getBaseInstantTime(), 
LESSER_THAN_OR_EQUALS, lastInstant.get().getTimestamp())) {
         return false;
       }
   
       return 
timeline.containsOrBeforeTimelineStarts(slice.getBaseInstantTime());
     }```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to