xushiyan commented on code in PR #8053:
URL: https://github.com/apache/hudi/pull/8053#discussion_r1118294290
##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncConfig.java:
##########
@@ -75,21 +85,26 @@ public class BigQuerySyncConfig extends HoodieSyncConfig
implements Serializable
public static final ConfigProperty<String> BIGQUERY_SYNC_SYNC_BASE_PATH =
ConfigProperty
.key("hoodie.gcp.bigquery.sync.base_path")
.noDefaultValue()
+ .withInferFunction(cfg ->
Option.ofNullable(cfg.getString(META_SYNC_BASE_PATH)))
.withDocumentation("Base path of the hoodie table to sync");
public static final ConfigProperty<String> BIGQUERY_SYNC_PARTITION_FIELDS =
ConfigProperty
.key("hoodie.gcp.bigquery.sync.partition_fields")
.noDefaultValue()
+ .withInferFunction(cfg ->
Option.ofNullable(cfg.getString(HoodieTableConfig.PARTITION_FIELDS))
+ .or(() ->
Option.ofNullable(cfg.getString(KeyGeneratorOptions.PARTITIONPATH_FIELD_NAME))))
.withDocumentation("Comma-delimited partition fields. Default to
non-partitioned.");
public static final ConfigProperty<Boolean>
BIGQUERY_SYNC_USE_FILE_LISTING_FROM_METADATA = ConfigProperty
.key("hoodie.gcp.bigquery.sync.use_file_listing_from_metadata")
- .defaultValue(false)
+ .defaultValue(DEFAULT_METADATA_ENABLE_FOR_READERS)
+ .withInferFunction(cfg ->
Option.of(cfg.getBooleanOrDefault(HoodieMetadataConfig.ENABLE,
DEFAULT_METADATA_ENABLE_FOR_READERS)))
.withDocumentation("Fetch file listing from Hudi's metadata");
- public static final ConfigProperty<Boolean>
BIGQUERY_SYNC_ASSUME_DATE_PARTITIONING = ConfigProperty
+ public static final ConfigProperty<String>
BIGQUERY_SYNC_ASSUME_DATE_PARTITIONING = ConfigProperty
Review Comment:
this is compatible. changing to string is to align with existing root config
`HoodieMetadataConfig.ASSUME_DATE_PARTITIONING`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
