bvaradar commented on code in PR #7615:
URL: https://github.com/apache/hudi/pull/7615#discussion_r1114003482
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -282,6 +282,8 @@ protected void commit(HoodieTable table, String
commitActionType, String instant
writeTableMetadata(table, instantTime, commitActionType, metadata);
activeTimeline.saveAsComplete(new HoodieInstant(true, commitActionType,
instantTime),
Option.of(metadata.toJsonString().getBytes(StandardCharsets.UTF_8)));
+ // reload active timeline
+ table.getMetaClient().reloadActiveTimeline();
}
Review Comment:
@Zouxxyy : Reloading timeline after commit would not be beneficial for cases
when archiving is run async as it would induce unnecessary filesystem calls. I
also agree with @danny0405 comment asking if this is really needed as the
archiver would archive the commit in the next run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
