chenshzh commented on PR #6121: URL: https://github.com/apache/hudi/pull/6121#issuecomment-1425538561
> > @danny0405 @yuzhaojing could you help review this pr? It has been here for a long time. > > Its purpose is clear that we should include errors/exceptions wrapped in compaction write status into rollback policies. > > Otherwise, it will still be committed even if this compaction has met with some data loss exceptions. > > I see there are so many code refactoring in the patch, can we have a quick fix in `CompactionCommitSink` and left the refactoring to maybe another PR? @danny0405 Already removed the refactoring part, and also added it to `ClusteringCommitSink` for the same reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
