vinothchandar commented on code in PR #7725:
URL: https://github.com/apache/hudi/pull/7725#discussion_r1083370844
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java:
##########
@@ -54,29 +54,36 @@ public static Comparator<String>
getReverseCommitTimeComparator() {
/**
* Timeline, based on which all getter work.
*/
- private final HoodieTimeline timeline;
+ private final HoodieTimeline completedTimeline;
+
+ /**
+ * Timeline, based on which all getter work.
Review Comment:
this is copy pasted from above?
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java:
##########
@@ -54,29 +54,36 @@ public static Comparator<String>
getReverseCommitTimeComparator() {
/**
* Timeline, based on which all getter work.
*/
- private final HoodieTimeline timeline;
+ private final HoodieTimeline completedTimeline;
+
+ /**
+ * Timeline, based on which all getter work.
+ */
+ private final HoodieTimeline writeTimeline;
/**
* The last completed instant, that acts as a high watermark for all getters.
*/
private final Option<HoodieInstant> lastInstant;
public HoodieFileGroup(HoodieFileGroup fileGroup) {
- this.timeline = fileGroup.timeline;
+ this.completedTimeline = fileGroup.completedTimeline;
+ this.writeTimeline = fileGroup.writeTimeline;
this.fileGroupId = fileGroup.fileGroupId;
this.fileSlices = new TreeMap<>(fileGroup.fileSlices);
this.lastInstant = fileGroup.lastInstant;
}
- public HoodieFileGroup(String partitionPath, String id, HoodieTimeline
timeline) {
- this(new HoodieFileGroupId(partitionPath, id), timeline);
+ public HoodieFileGroup(String partitionPath, String id, HoodieTimeline
completedTimeline, HoodieTimeline writeTimeline) {
Review Comment:
hmmm. not sure I am a fan of this. but need to understand fully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
