danny0405 commented on code in PR #7608:
URL: https://github.com/apache/hudi/pull/7608#discussion_r1064257815
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java:
##########
@@ -69,7 +77,6 @@ public class HoodieTableFactory implements
DynamicTableSourceFactory, DynamicTab
public DynamicTableSource createDynamicTableSource(Context context) {
Configuration conf =
FlinkOptions.fromMap(context.getCatalogTable().getOptions());
ResolvedSchema schema = context.getCatalogTable().getResolvedSchema();
- sanityCheck(conf, schema);
setupConfOptions(conf, context.getObjectIdentifier(),
context.getCatalogTable(), schema);
Review Comment:
Yeah, mering happens for mor table no matter whether the consuming is
streaming or batch.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -134,7 +155,9 @@ public HoodieKey getHoodieKey(RowData rowData) {
}
public String getRecordKey(RowData rowData) {
- if (this.simpleRecordKey) {
+ if (!hasRecordKey) {
+ return DEFAULT_RECORD_KEY;
+ } else if (this.simpleRecordKey) {
Review Comment:
In #7622, empty string is also used for keyless primary keys, so it's okey
here if we reach an agreement and never uses the primary key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
