umehrot2 commented on pull request #1596: URL: https://github.com/apache/incubator-hudi/pull/1596#issuecomment-629173116
@rolandjohann The fix makes sense to me. Lets add a test for decimal type handling, and make it nested within another type as well. Recently we have tried to exhaustively test as many data types handling as possible, by adding fields with those data types in the schema for test data that Hudi uses across various tests: https://github.com/apache/incubator-hudi/blob/master/hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java#L95 . We recently added **Map** and **Array** types test. What you can do is add a **decimal** field to the trip record schema as a nested type. Infact, easy solution with be in **FARE_NESTED_SCHEMA** change the type of **amount** from **double** to **decimal**. **double** is either ways tested through other fields, this would accurately test **decimal** field in **nested** schema. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
