nsivabalan commented on code in PR #7171:
URL: https://github.com/apache/hudi/pull/7171#discussion_r1018623450
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java:
##########
@@ -250,7 +250,7 @@ static HoodieDeltaStreamer.Config makeConfig(String
basePath, WriteOperationType
cfg.operation = op;
cfg.enableHiveSync = enableHiveSync;
cfg.sourceOrderingField = sourceOrderingField;
- cfg.propsFilePath = dfsBasePath + "/" + propsFilename;
+ cfg.propsFilePath = UtilitiesTestBase.basePath + "/" + propsFilename;
Review Comment:
basePath is protected in UtilitiesTestBase and TestHoodieDeltastreamer
extends from it. so why prefixing with class name ?
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java:
##########
@@ -272,7 +272,7 @@ static HoodieDeltaStreamer.Config
makeConfigForHudiIncrSrc(String srcBasePath, S
cfg.sourceClassName = HoodieIncrSource.class.getName();
cfg.operation = op;
cfg.sourceOrderingField = "timestamp";
- cfg.propsFilePath = dfsBasePath + "/test-downstream-source.properties";
+ cfg.propsFilePath = UtilitiesTestBase.basePath +
"/test-downstream-source.properties";
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
