[GitHub] [hudi] YannByron commented on a diff in pull request #6705: [HUDI-4868] Fixed the issue that compaction is invalid when the last commit action is replace commit.

Tue, 25 Oct 2022 02:44:04 -0700 


YannByron commented on code in PR #6705:
URL: https://github.com/apache/hudi/pull/6705#discussion_r1004248356


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/cdc/TestCDCDataFrameSuite.scala:
##########
@@ -228,7 +227,8 @@ class TestCDCDataFrameSuite extends HoodieCDCTestBase {
   def testMORDataSourceWrite(cdcSupplementalLoggingMode: String): Unit = {
     val options = commonOpts ++ Map(
       DataSourceWriteOptions.TABLE_TYPE.key() -> 
DataSourceWriteOptions.MOR_TABLE_TYPE_OPT_VAL,
-      HoodieTableConfig.CDC_SUPPLEMENTAL_LOGGING_MODE.key -> 
cdcSupplementalLoggingMode
+      HoodieTableConfig.CDC_SUPPLEMENTAL_LOGGING_MODE.key -> 
cdcSupplementalLoggingMode,
+      HoodieCleanConfig.AUTO_CLEAN.key -> "false"

Review Comment:
   why need to set `HoodieCleanConfig.AUTO_CLEAN` here. This config has been 
set in `commonOpts`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to