alexeykudinkin commented on code in PR #5091:
URL: https://github.com/apache/hudi/pull/5091#discussion_r965235941
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -231,7 +232,7 @@ public List<Pair<String,
Option<HoodieRecord<HoodieMetadataPayload>>>> getRecord
throw new HoodieIOException("Error merging records from metadata table
for " + sortedKeys.size() + " key : ", ioe);
} finally {
if (!reuse) {
- close(Pair.of(partitionFileSlicePair.getLeft(),
partitionFileSlicePair.getRight().getFileId()));
Review Comment:
Yeah, we should rewrite it to use `closeReader` instead
```
private void closePartitionReaders() {
for (Pair<...> pair : partitionReaders.values()) {
closeReader(pair);
}
partitionReaders.clear();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
