dongkelun commented on code in PR #5478:
URL: https://github.com/apache/hudi/pull/5478#discussion_r964283533
##########
hudi-common/src/main/avro/HoodieCleanMetadata.avsc:
##########
@@ -23,6 +23,7 @@
{"name": "timeTakenInMillis", "type": "long"},
{"name": "totalFilesDeleted", "type": "int"},
{"name": "earliestCommitToRetain", "type": "string"},
+ {"name": "lastCompletedCommitTimestamp", "type": "string", "default" :
""},
Review Comment:
As I mentioned earlier, the main reason is to be compatible with the old
version. The default value should not be null,
```scala
numCommits =
commitTimeline.findInstantsAfter(lastCompletedCommitTimestamp).countInstants()
```
Null and empty return different results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
