xushiyan commented on code in PR #6170:
URL: https://github.com/apache/hudi/pull/6170#discussion_r947300784
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/callback/http/TestCallbackHttpClient.java:
##########
@@ -70,7 +71,7 @@ public class TestCallbackHttpClient {
@BeforeEach
void prepareAppender() {
- when(appender.getName()).thenReturn("MockAppender");
+ when(appender.getName()).thenReturn("MockAppender-" + UUID.randomUUID());
Review Comment:
good catch!
##########
hudi-client/hudi-client-common/src/main/resources/log4j2.properties:
##########
@@ -15,9 +15,16 @@
# See the License for the specific language governing permissions and
# limitations under the License.
###
-log4j.rootLogger=INFO, A1
-# A1 is set to be a ConsoleAppender.
-log4j.appender.A1=org.apache.log4j.ConsoleAppender
-# A1 uses PatternLayout.
-log4j.appender.A1.layout=org.apache.log4j.PatternLayout
-log4j.appender.A1.layout.ConversionPattern=%-4r [%t] %-5p %c %x - %m%n
+status = warn
+name = HudiConsoleLog
Review Comment:
it anyway looks like an anti-pattern to bundle production log properties. we
should remove it and mark it as a migration item for next major release, if it
breaks anything.
##########
hudi-client/hudi-client-common/pom.xml:
##########
@@ -193,6 +193,12 @@
</dependency>
<!-- Test -->
+ <dependency>
+ <groupId>org.apache.hudi</groupId>
+ <artifactId>hudi-tests-common</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+ </dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
Review Comment:
still an exception in `TestFSUtils` where import org.junit.Rule; is used to
inject env var, where it's not doable in junit 5, last time i checked.
##########
docker/demo/config/log4j2.properties:
##########
@@ -0,0 +1,60 @@
+###
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###
+status = warn
+name = HudiConsoleLog
+
+# Set everything to be logged to the console
+appender.console.type = Console
+appender.console.name = CONSOLE
+appender.console.layout.type = PatternLayout
+appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
+
+# Root logger level
+rootLogger.level = warn
+# Root logger referring to console appender
+rootLogger.appenderRef.stdout.ref = CONSOLE
+
+# Set the default spark-shell log level to WARN. When running the spark-shell,
the
+# log level for this class is used to overwrite the root logger's log level,
so that
+# the user can have different defaults for the shell and regular Spark apps.
+logger.apache_spark_repl.name = org.apache.spark.repl.Main
+logger.apache_spark_repl.level = warn
+# Set logging of integration testsuite to INFO level
+logger.hudi_integ.name = org.apache.hudi.integ.testsuite
+logger.hudi_integ.level = info
+# Settings to quiet third party logs that are too verbose
+logger.apache_spark_jetty.name = org.spark_project.jetty
+logger.apache_spark_jetty.level = warn
+logger.apache_spark_jett_lifecycle.name =
org.spark_project.jetty.util.component.AbstractLifeCycle
Review Comment:
is this about allowing users to fine-tune the logging level for different
loggers? i felt in Hudi we don't have to maintain these. users should just
override for the loggers they need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
