nsivabalan commented on code in PR #5245:
URL: https://github.com/apache/hudi/pull/5245#discussion_r931813254


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1113,9 +1113,28 @@ protected Map<String, Option<HoodiePendingRollbackInfo>> 
getPendingRollbackInfos
   protected Map<String, Option<HoodiePendingRollbackInfo>> 
getPendingRollbackInfos(HoodieTableMetaClient metaClient, boolean 
ignoreCompactionAndClusteringInstants) {
     List<HoodieInstant> instants = 
metaClient.getActiveTimeline().filterPendingRollbackTimeline().getInstants().collect(Collectors.toList());
     Map<String, Option<HoodiePendingRollbackInfo>> infoMap = new HashMap<>();
-    for (HoodieInstant instant : instants) {
+    for (HoodieInstant rollbackInstant : instants) {
+      HoodieRollbackPlan rollbackPlan;
+      try {
+        rollbackPlan = RollbackUtils.getRollbackPlan(metaClient, 
rollbackInstant);
+      } catch (IOException e) {

Review Comment:
   yes. probably we should catch only for the known exception and stacktrace as 
well.
   ```
   Caused by: java.io.IOException: Not an Avro data fileat 
org.apache.avro.file.DataFileReader.openReader(DataFileReader.java:50)
   ```
   
   this is the stacktrace when avro file is corrupt. we will follow up w/ the 
right fix. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to