xushiyan commented on code in PR #5943:
URL: https://github.com/apache/hudi/pull/5943#discussion_r930123936


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieStorageConfig.java:
##########
@@ -130,6 +130,16 @@ public class HoodieStorageConfig extends HoodieConfig {
       .defaultValue("TIMESTAMP_MICROS")
       .withDocumentation("Sets spark.sql.parquet.outputTimestampType. Parquet 
timestamp type to use when Spark writes data to Parquet files.");
 
+  // SPARK-38094 Spark 3.3 checks if this field is enabled. Hudi has to 
provide this or there would be NPE thrown
+  // Would ONLY be effective with Spark 3.3+
+  // default value is true which is in accordance with Spark 3.3
+  public static final ConfigProperty<String> PARQUET_FIELD_ID_WRITE_ENABLED = 
ConfigProperty
+      .key("hoodie.parquet.fieldId.write.enabled")

Review Comment:
   hoodie config keys follow snake case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to