codope commented on code in PR #6214:
URL: https://github.com/apache/hudi/pull/6214#discussion_r929502601
##########
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java:
##########
@@ -131,10 +133,13 @@ public List<String> getAllPartitionPaths() throws
IOException {
public FileStatus[] getAllFilesInPartition(Path partitionPath)
throws IOException {
if (isMetadataTableEnabled) {
- try {
- return fetchAllFilesInPartition(partitionPath);
- } catch (Exception e) {
- throw new HoodieMetadataException("Failed to retrieve files in
partition " + partitionPath + " from metadata", e);
+ synchronized (cachedFileListingLock) {
Review Comment:
So, this should only be done when cachedFileListing is enabled right?
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -92,6 +93,7 @@ public class HoodieBackedTableMetadata extends
BaseTableMetadata {
private HoodieTableConfig metadataTableConfig;
// should we reuse the open file handles, across calls
private final boolean reuse;
+ private final boolean cacheFileListing;
Review Comment:
I assume this flag will be set as a session prop in Presto. But, where are
we using this flag in metadata fs view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
