CTTY commented on code in PR #5943:
URL: https://github.com/apache/hudi/pull/5943#discussion_r929458641
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala:
##########
@@ -421,12 +433,10 @@ case class HoodieResolveReferences(sparkSession:
SparkSession) extends Rule[Logi
UpdateTable(table, resolvedAssignments, resolvedCondition)
// Resolve Delete Table
- case DeleteFromTable(table, condition)
+ case dft @ DeleteFromTable(table, condition)
if sparkAdapter.isHoodieTable(table, sparkSession) && table.resolved =>
- // Resolve condition
- val resolvedCondition = condition.map(resolveExpressionFrom(table)(_))
- // Return the resolved DeleteTable
- DeleteFromTable(table, resolvedCondition)
+ val resolveExpression = resolveExpressionFrom(table, None)_
+ sparkAdapter.resolveDeleteFromTable(dft, resolveExpression)
Review Comment:
We can, but I was thinking about reusing this method for the type matching
in `DeleteHoodieTableCommand`. Haven't got a good idea tho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
