danny0405 commented on code in PR #6093:
URL: https://github.com/apache/hudi/pull/6093#discussion_r928524041


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSink.java:
##########
@@ -95,6 +95,10 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context 
context) {
       pipeline = Pipelines.hoodieStreamWrite(conf, parallelism, 
hoodieRecordDataStream);
       // compaction
       if (OptionsResolver.needsAsyncCompaction(conf)) {
+        // batch mode write must use syncCompaction.
+        if (context.isBounded()) {
+          conf.setBoolean(FlinkOptions.COMPACTION_ASYNC_ENABLED, false);

Review Comment:
   Not exactly, because the bounded source can also be long running.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to