codope commented on code in PR #5643:
URL: https://github.com/apache/hudi/pull/5643#discussion_r927512213
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -349,7 +349,7 @@ public class HoodieWriteConfig extends HoodieConfig {
public static final ConfigProperty<String>
EMBEDDED_TIMELINE_SERVER_USE_ASYNC_ENABLE = ConfigProperty
.key("hoodie.embed.timeline.server.async")
- .defaultValue("false")
+ .defaultValue("true")
.withDocumentation("Controls whether or not, the requests to the
timeline server are processed in asynchronous fashion, "
Review Comment:
I see. The intent is to improve the throughput by requesting the timeline
server asynchronously. Internally, we have run a long-running test (30+
commits) with this config but did not see any data loss. Our validations were
based on count. However, if you have any concern let me know. We can keep it
false by default for now. Data loss issues are more critical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
