yanghua commented on code in PR #5797:
URL: https://github.com/apache/hudi/pull/5797#discussion_r925708959
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1557,6 +1557,10 @@ public boolean getHbaseIndexUpdatePartitionPath() {
return
getBooleanOrDefault(HoodieHBaseIndexConfig.UPDATE_PARTITION_PATH_ENABLE);
}
+ public int getHBaseIndexRegionCount() {
+ return getInt(HoodieHBaseIndexConfig.BUCKET_NUMBER);
+ }
+
Review Comment:
Yes, I feel like this class is a hodgepodge and is ballooning. It does not
demonstrate the benefits of configuration separation that a pluggable
architecture should bring. WDYT about it? @xushiyan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
