YannByron commented on code in PR #5885: URL: https://github.com/apache/hudi/pull/5885#discussion_r923292144
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java: ########## @@ -102,6 +117,15 @@ protected Map<String, HoodieRecord<T>> keyToNewRecords; protected Set<String> writtenRecordKeys; protected HoodieFileWriter<IndexedRecord> fileWriter; + // a flag that indicate whether allow the change data to write out a cdc log file. + protected boolean cdcEnabled = false; Review Comment: hi @prasannarajaperumal i try to create some sub-classes `HoodieChangeTrackingMergeHandle`, `HoodieChangeTrackingSortedMergeHandle` and `HoodieChangeTrackingConcatHandle`, and add the logical to judge whether `HoodieChangeTrackingXXXHandle` should be created at all the places where `HoodieMergeHandle` and other classes are created before. I think it is maybe less clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
