zhedoubushishi commented on code in PR #4915:
URL: https://github.com/apache/hudi/pull/4915#discussion_r918385731
##########
hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java:
##########
@@ -174,6 +174,11 @@ public static TypedProperties getGlobalProps() {
return globalProps;
}
+ public static TypedProperties addToGlobalProps(String key, String value) {
Review Comment:
Yes this is a good point. Flink has its own @VisitbleForTesting. However, in
hudi-common package, I think Hudi doesn't want to use Guava as its dependency:
https://github.com/apache/hudi/blob/master/style/checkstyle.xml#L270. But for
the long term, I agree we should think a way to resolve this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
