rahil-c commented on code in PR #5786:
URL: https://github.com/apache/hudi/pull/5786#discussion_r918141727
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HiveIncrementalPuller.java:
##########
@@ -214,8 +214,6 @@ private void initHiveBeelineProperties(Statement stmt)
throws SQLException {
executeStatement("set mapred.job.queue.name=" + config.yarnQueueName,
stmt);
// Set the inputFormat to HoodieCombineHiveInputFormat
executeStatement("set
hive.input.format=org.apache.hudi.hadoop.hive.HoodieCombineHiveInputFormat",
stmt);
- // Allow queries without partition predicate
- executeStatement("set hive.strict.checks.large.query=false", stmt);
Review Comment:
Actually we should not keep this, as it caused errors in the actual test.
The reason being that this param existed in Hive 2.3.x
https://github.com/apache/hive/blob/release-2.3.8-rc3/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
whereas in Hive 3.1.2 it has been removed. The below properties for
`hive.strict.checks` are as follows
```
HIVE_STRICT_CHECKS_ORDERBY_NO_LIMIT("hive.strict.checks.orderby.no.limit",
false,
"Enabling strict large query checks disallows the following:\n" +
" Orderby without limit.\n" +
"Note that this check currently does not consider data size, only
the query pattern."),
HIVE_STRICT_CHECKS_NO_PARTITION_FILTER("hive.strict.checks.no.partition.filter",
false,
"Enabling strict large query checks disallows the following:\n" +
" No partition being picked up for a query against partitioned
table.\n" +
"Note that this check currently does not consider data size, only
the query pattern."),
HIVE_STRICT_CHECKS_TYPE_SAFETY("hive.strict.checks.type.safety", true,
"Enabling strict type safety checks disallows the following:\n" +
" Comparing bigints and strings.\n" +
" Comparing bigints and doubles."),
HIVE_STRICT_CHECKS_CARTESIAN("hive.strict.checks.cartesian.product",
false,
"Enabling strict Cartesian join checks disallows the following:\n" +
" Cartesian product (cross join)."),
HIVE_STRICT_CHECKS_BUCKETING("hive.strict.checks.bucketing", true,
"Enabling strict bucketing checks disallows the following:\n" +
" Load into bucketed tables."),
HIVE_LOAD_DATA_OWNER("hive.load.data.owner", "",
"Set the owner of files loaded using load data in managed tables."),
@Deprecated
HIVEMAPREDMODE("hive.mapred.mode", null,
"Deprecated; use hive.strict.checks.* settings instead."),
```
https://github.com/apache/hive/blob/rel/release-3.1.0/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
