xushiyan commented on code in PR #5854:
URL: https://github.com/apache/hudi/pull/5854#discussion_r912321557
##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncTool.java:
##########
@@ -40,26 +47,28 @@
*
* @Experimental
*/
-public class BigQuerySyncTool extends AbstractSyncTool {
+public class BigQuerySyncTool extends HoodieSyncTool {
private static final Logger LOG =
LogManager.getLogger(BigQuerySyncTool.class);
- public final BigQuerySyncConfig cfg;
+ public final BigQuerySyncConfig config;
+ public final String tableName;
public final String manifestTableName;
public final String versionsTableName;
public final String snapshotViewName;
- public BigQuerySyncTool(TypedProperties properties, Configuration conf,
FileSystem fs) {
- super(properties, conf, fs);
- cfg = BigQuerySyncConfig.fromProps(properties);
- manifestTableName = cfg.tableName + "_manifest";
- versionsTableName = cfg.tableName + "_versions";
- snapshotViewName = cfg.tableName;
+ public BigQuerySyncTool(Properties props) {
+ super(props);
+ this.config = new BigQuerySyncConfig(props);
+ this.tableName = config.getString(BIGQUERY_SYNC_TABLE_NAME);
Review Comment:
BigQuerySyncConfigParams required this arg. In follow up PR, we should make
it optional anyway; make it inferred from table properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
