LinMingQiang commented on code in PR #5937:
URL: https://github.com/apache/hudi/pull/5937#discussion_r911060889
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteMergeOnRead.java:
##########
@@ -59,6 +102,113 @@ public void
testIndexStateBootstrapWithCompactionScheduled() throws Exception {
validateIndexLoaded();
}
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ public void testPrecombinFieldOnSnapshotQuery(boolean enableChangelog)
throws Exception {
+ String path = tempFile.getAbsolutePath();
+ EnvironmentSettings settings =
EnvironmentSettings.newInstance().inBatchMode().build();
+ TableEnvironment tableEnv = TableEnvironmentImpl.create(settings);
Review Comment:
resolved~
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadInputFormat.java:
##########
@@ -753,7 +758,7 @@ private Option<IndexedRecord> mergeRowWithLog(
String curKey) throws IOException {
final HoodieAvroRecord<?> record = (HoodieAvroRecord)
scanner.getRecords().get(curKey);
GenericRecord historyAvroRecord = (GenericRecord)
rowDataToAvroConverter.convert(tableSchema, curRow);
- return record.getData().combineAndGetUpdateValue(historyAvroRecord,
tableSchema);
+ return record.getData().combineAndGetUpdateValue(historyAvroRecord,
tableSchema, payloadConf);
Review Comment:
resolved~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
