LinMingQiang commented on code in PR #5937:
URL: https://github.com/apache/hudi/pull/5937#discussion_r907110462
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/utils/TestWriteBase.java:
##########
@@ -353,6 +361,21 @@ private void checkWrittenDataMor(File baseFile,
Map<String, String> expected, in
TestData.checkWrittenDataMOR(fs, latestInstant, baseFile, expected,
partitions, schema);
}
+ public TestHarness checkWrittenDataMergedMor(
+ ResolvedSchema schema,
+ String expected) throws Exception {
+ HoodieTableSource tableSource = new HoodieTableSource(
+ schema,
+ new Path(this.basePath),
+
Arrays.asList(conf.getString(FlinkOptions.PARTITION_PATH_FIELD).split(",")),
Review Comment:
`TestWriteBase#checkWrittenData` can only reads the log file or only reads
the parquet file, And the purpose of this `test case` is to test whether
`MergeOnReadInputFormat` can sort and de duplicate as expected. That's what I
think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
